From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755971AbYELQxU@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755971AbYELQxU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 12 May 2008 12:53:20 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753617AbYELQxG
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 12 May 2008 12:53:06 -0400
Received: from mgw2.diku.dk ([130.225.96.92]:51778 "EHLO mgw2.diku.dk"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753548AbYELQxF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 12 May 2008 12:53:05 -0400
Date: Mon, 12 May 2008 18:53:01 +0200 (CEST)
From: Julia Lawall <julia@diku.dk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference
In-Reply-To: <20080512161734.GA22190@electric-eye.fr.zoreil.com>
Message-ID: <Pine.LNX.4.64.0805121852510.16384@ask.diku.dk>
References: <Pine.LNX.4.64.0805121537320.3694@ask.diku.dk>
 <20080512161734.GA22190@electric-eye.fr.zoreil.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 12 May 2008, Francois Romieu wrote:

> Julia Lawall <julia@diku.dk> :
> [...]
> > diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> > --- a/drivers/net/au1000_eth.c	2008-04-27 11:41:11.000000000 +0200
> > +++ b/drivers/net/au1000_eth.c	2008-05-12 09:32:54.000000000 +0200
> > @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int 
> >  	struct net_device *dev = (struct net_device *) dev_id;
> >  
> >  	if (dev == NULL) {
> > -		printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
> > +		printk(KERN_ERR "isr: null dev ptr\n");
> >  		return IRQ_RETVAL(1);
> >  	}
> 
> The lifespan of 'dev' covers the request_irq..free_irq interval in this
> driver. The whole 'dev == NULL' block can be removed.

Will you do that?

julia