From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757712AbYELSsa (ORCPT ); Mon, 12 May 2008 14:48:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756535AbYELSsU (ORCPT ); Mon, 12 May 2008 14:48:20 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:37344 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756489AbYELSsS (ORCPT ); Mon, 12 May 2008 14:48:18 -0400 Date: Mon, 12 May 2008 20:48:15 +0200 (CEST) From: Julia Lawall To: Jeff Garzik Cc: Francois Romieu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference In-Reply-To: <48287916.2090203@pobox.com> Message-ID: References: <20080512161734.GA22190@electric-eye.fr.zoreil.com> <48287916.2090203@pobox.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 May 2008, Jeff Garzik wrote: > Julia Lawall wrote: > > On Mon, 12 May 2008, Francois Romieu wrote: > > > > > Julia Lawall : > > > [...] > > > > diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c > > > > --- a/drivers/net/au1000_eth.c 2008-04-27 11:41:11.000000000 +0200 > > > > +++ b/drivers/net/au1000_eth.c 2008-05-12 09:32:54.000000000 +0200 > >>> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int > > > > struct net_device *dev = (struct net_device *) dev_id; > > > > > > > > if (dev == NULL) { > > > > - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name); > > > > + printk(KERN_ERR "isr: null dev ptr\n"); > > > > return IRQ_RETVAL(1); > > > > } > > > The lifespan of 'dev' covers the request_irq..free_irq interval in this > > > driver. The whole 'dev == NULL' block can be removed. > > > > Will you do that? > > It's normal within the Linux community to give feedback on patches, and > sometimes the authors need to revise their patches if helpful feedback arises. Sorry. In principle, I would be happy to do it, but I felt slightly uneasy about doing something I didn't completely understand. julia