From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbYEPHBF (ORCPT ); Fri, 16 May 2008 03:01:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751740AbYEPHAy (ORCPT ); Fri, 16 May 2008 03:00:54 -0400 Received: from edna.telenet-ops.be ([195.130.132.58]:38457 "EHLO edna.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbYEPHAw (ORCPT ); Fri, 16 May 2008 03:00:52 -0400 Date: Fri, 16 May 2008 09:00:48 +0200 (CEST) From: Geert Uytterhoeven To: Andrew Morton cc: Cyrill Gorcunov , torvalds@linux-foundation.org, zippel@linux-m68k.org, schwab@suse.de, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org Subject: Re: [PATCH] init - fix building bug and potential buffer overflow In-Reply-To: <20080515134928.83b2d948.akpm@linux-foundation.org> Message-ID: References: <20080514154402.GF6902@cvg> <20080515105803.7c9ab8c7.akpm@linux-foundation.org> <20080515180528.GC7481@cvg> <20080515134928.83b2d948.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 May 2008, Andrew Morton wrote: > On Fri, 16 May 2008 00:22:14 +0400 > "Cyrill Gorcunov" wrote: > > On 5/15/08, Geert Uytterhoeven wrote: > > > On Thu, 15 May 2008, Cyrill Gorcunov wrote: > > >> [Andrew Morton - Thu, May 15, 2008 at 10:58:03AM -0700] > > >> | On Wed, 14 May 2008 19:44:02 +0400 Cyrill Gorcunov > > >> wrote: > > >> strlcat there but it seems it would fail to build too. Originally I've > > >> messed > > >> strlcat with strncat :( > > > > > > Actually it build and runs fine after s/strncat/strlcat/... > > > > > (top-posting repaired) > > > Could you please make an update to the patch? I can make it only > > tomorrow evening (ie not that fast) > > Like this? Builds and boots fine! > From: Cyrill Gorcunov > > This patch fixes a build bug on m68k - gcc decides to emit a call to the > strlen library function, which we don't implement. Use strlcat() instead. > > > What is more important - my previous patch > > commit e662e1cfd434aa234b72fbc781f1d70211cb785b > Author: Cyrill Gorcunov > Date: Mon May 12 14:02:22 2008 -0700 > > init: don't lose initcall return values > > Has introduced potential buffer overflow by wrong calculation of string > accumulator size. > > Many thanks Andreas Schwab and Geert Uytterhoeven for helping > to catch and fix the bug. > > Signed-off-by: Cyrill Gorcunov > Cc: Geert Uytterhoeven > Signed-off-by: Andrew Morton Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds