From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
fabrizio.garetto@gmail.com, jonsmirl@gmail.com
Subject: Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
Date: Mon, 19 May 2008 18:30:38 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0805191811510.29559@axis700.grange> (raw)
In-Reply-To: <fa686aa40805190857u317d3304ie75d11870e109fc5@mail.gmail.com>
On Mon, 19 May 2008, Grant Likely wrote:
> On Mon, May 19, 2008 at 7:17 AM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > On Fri, 16 May 2008, Grant Likely wrote:
> >
> >> + However, the binding does not attempt to define the specific method for
> >> + assigning chip select numbers. Since SPI chip select configuration is
> >> + flexible and non-standardized, it is left out of this binding with the
> >> + assumption that board specific platform code will be used to manage
> >> + chip selects. Individual drivers can define additional properties to
> >> + support describing the chip select layout.
> >
> > Yes, this looks like a problem to me. This means, SPI devices will need
> > two bindings - OF and platform?... Maybe define an spi_chipselect
> > OF-binding?
>
> Actually, spi devices have *neither*. :-) They bind to the SPI bus.
> Not the platform bus or of_platform bus.
Right, sorry, your SPI bus driver scans the bus device bindings and
registers devices on it using spi_of_register_devices().
> But that is Linux internal
> details; this discussion is about device tree bindings.
>
> Note that I did say that drivers can define additional properties for
> supporting chip select changes as needed. I'm just not attempting to
> encode them into the formal binding. There is simply just too many
> different ways to manipulate chip select signals and so I don't feel
> confident trying to define a *common* binding at this moment in time.
Yes, I understand, that physically there can be many ways SPI chipselects
can be controlled. But I thought there could be a generic way to cover
them all by defining a separate entry on your SPI bus. Like
+ SPI example for an MPC5200 SPI bus:
+ spi@f00 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,mpc5200b-spi","fsl,mpc5200-spi";
+ reg = <0xf00 0x20>;
+ interrupts = <2 13 0 2 14 0>;
+ interrupt-parent = <&mpc5200_pic>;
+ eth-switch-cs@0 {
+ compatible = "oem,cs-type";
+ };
+
+ ethernet-switch@0 {
+ compatible = "micrel,ks8995m";
+ linux,modalias = "ks8995";
+ max-speed = <1000000>;
+ reg = <0>;
+ cs-parent = <&/.../spi@f00/eth-switch-cs@0>;
+ };
...
+ };
Then whatever method is used to actually switch the CS, a driver should be
registered to handle eth-switch-cs@0, providing the required calls.
Without such a driver ethernet-switch@0 will not probe successfully.
Wouldn't this cover all possible cases? One could even consider actually
putting SPI devices on SPI chipselect busses, but that won't look very
elegant:-)
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
next prev parent reply other threads:[~2008-05-19 16:30 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 19:35 [RFC PATCH 0/4] Describe SPI devices in the OF device tree and add mpc5200-spi driver Grant Likely
2008-05-16 19:36 ` [PATCH 1/4] spi: Change modalias from a pointer to a character array Grant Likely
2008-05-16 19:36 ` [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration Grant Likely
2008-05-22 0:17 ` David Brownell
2008-05-24 6:43 ` Grant Likely
2008-05-24 6:54 ` Grant Likely
2008-06-30 4:08 ` David Brownell
2008-06-17 7:28 ` Grant Likely
2008-06-30 4:10 ` David Brownell
2008-05-16 19:36 ` [PATCH 3/4] spi: Add OF binding support for SPI busses Grant Likely
2008-05-16 20:47 ` Randy Dunlap
2008-05-16 20:51 ` Grant Likely
2008-05-16 22:03 ` Anton Vorontsov
2008-05-16 22:14 ` Grant Likely
2008-05-16 22:49 ` Anton Vorontsov
2008-05-17 5:02 ` Grant Likely
2008-05-22 1:16 ` David Brownell
2008-05-24 6:24 ` Grant Likely
2008-05-19 13:17 ` Guennadi Liakhovetski
2008-05-19 15:57 ` Grant Likely
2008-05-19 16:30 ` Guennadi Liakhovetski [this message]
2008-05-20 5:13 ` Grant Likely
2008-05-20 15:26 ` Guennadi Liakhovetski
2008-05-20 15:48 ` Grant Likely
2008-05-21 19:11 ` Segher Boessenkool
2008-05-21 19:33 ` Grant Likely
2008-05-23 2:26 ` [spi-devel-general] " David Brownell
2008-05-24 6:25 ` Grant Likely
2008-05-24 7:13 ` David Brownell
2008-05-19 17:09 ` Gary Jennejohn
2008-05-19 17:19 ` Anton Vorontsov
2008-05-21 15:19 ` Anton Vorontsov
2008-05-23 2:05 ` David Brownell
2008-05-24 6:26 ` Grant Likely
2008-05-24 16:50 ` Grant Likely
2008-05-24 17:14 ` Jochen Friedrich
2008-05-24 17:33 ` Grant Likely
2008-05-24 17:45 ` David Brownell
2008-05-25 4:56 ` Grant Likely
2008-05-24 17:43 ` David Brownell
2008-05-16 19:36 ` [PATCH 4/4] [CSB] Add new mpc5200-spi (non-psc) device driver Grant Likely
2008-05-16 19:42 ` Grant Likely
2008-05-16 20:27 ` [RFC PATCH 0/4] Describe SPI devices in the OF device tree and add mpc5200-spi driver Jon Smirl
2008-05-16 20:48 ` Grant Likely
2008-05-16 21:25 ` Jon Smirl
2008-05-16 21:32 ` Grant Likely
2008-05-16 21:42 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805191811510.29559@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=dbrownell@users.sourceforge.net \
--cc=fabrizio.garetto@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®