From: Christoph Lameter <clameter@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, lethal@linux-sh.org,
dhowells@redhat.com
Subject: Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through
Date: Wed, 21 May 2008 14:12:01 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805211411050.17853@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <483473EA.40901@cs.helsinki.fi>
On Wed, 21 May 2008, Pekka Enberg wrote:
> Matt Mackall wrote:
> > We already know users (ie nommu memory usage reporting) are abusing this
> > interface. Making them blow up is unnecessary. Just give them wrong
> > answers. Issuing a warning might be a good idea for debugging.
>
> But kobjsize() never calls ksize() with SLOB as it doesn't set PageSlab. Or
> are you talking about something else here?
>
> Matt Mackall wrote:
> > Second, I'd prefer to keep this sort of debugging code out of SLOB.
> > SLUB is much better suited to debugging allocator abuse.
>
> Fair enough. I'll drop the patch.
I also would prefer to keep this out of SLUB. Set/Clear PageSlab dirties
the cacheline and it forces the unlining of kmalloc_large.
next prev parent reply other threads:[~2008-05-21 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:26 Pekka J Enberg
2008-05-21 19:07 ` Matt Mackall
2008-05-21 19:11 ` Pekka Enberg
2008-05-21 21:12 ` Christoph Lameter [this message]
2008-05-21 21:13 ` Pekka Enberg
2008-05-21 21:16 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805211411050.17853@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®