From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937469AbYEUVRK (ORCPT ); Wed, 21 May 2008 17:17:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S937009AbYEUVQm (ORCPT ); Wed, 21 May 2008 17:16:42 -0400 Received: from relay1.sgi.com ([192.48.171.29]:51851 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S937789AbYEUVQl (ORCPT ); Wed, 21 May 2008 17:16:41 -0400 Date: Wed, 21 May 2008 14:16:40 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Pekka Enberg cc: Matt Mackall , linux-kernel@vger.kernel.org, lethal@linux-sh.org, dhowells@redhat.com Subject: Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through In-Reply-To: <4834905E.9010802@cs.helsinki.fi> Message-ID: References: <1211396840.18026.276.camel@calx> <483473EA.40901@cs.helsinki.fi> <4834905E.9010802@cs.helsinki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 May 2008, Pekka Enberg wrote: > Christoph Lameter wrote: > > I also would prefer to keep this out of SLUB. Set/Clear PageSlab dirties the > > cacheline and it forces the unlining of kmalloc_large. > > Hmm, well, that leaves ksize() open for more abuse. I guess we'll just have to > live with that then. SLUB could add a BUG_ON(!PageCompound ) since we added buffering for order 0 allocs. So only order 1 and higher go through kmalloc large. That should catch the general case.