From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937252AbYEUUfq (ORCPT ); Wed, 21 May 2008 16:35:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764517AbYEUUfh (ORCPT ); Wed, 21 May 2008 16:35:37 -0400 Received: from smtp-vbr14.xs4all.nl ([194.109.24.34]:1570 "EHLO smtp-vbr14.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763719AbYEUUfg (ORCPT ); Wed, 21 May 2008 16:35:36 -0400 Date: Wed, 21 May 2008 22:35:23 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@localhost.localdomain To: Miklos Szeredi cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [patch 06/14] hfsplus: remove hfsplus_permission() In-Reply-To: <20080521171549.964767446@szeredi.hu> Message-ID: References: <20080521171458.077908538@szeredi.hu> <20080521171549.964767446@szeredi.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 21 May 2008, Miklos Szeredi wrote: > From: Miklos Szeredi > > I'm not sure what this function is trying to achieve, but it's not > succeeding: the condition for which it is returning zero is exactly > the same as checked by permission(), which results in -EACCES. > > So in the end this is equivalent to the default action. No, it's not, it allows for HFS+ specific special case to allow the lookup of the resource fork. bye, Roman