From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbYEWQbk (ORCPT ); Fri, 23 May 2008 12:31:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751067AbYEWQb3 (ORCPT ); Fri, 23 May 2008 12:31:29 -0400 Received: from smtp-vbr12.xs4all.nl ([194.109.24.32]:3525 "EHLO smtp-vbr12.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbYEWQbZ (ORCPT ); Fri, 23 May 2008 12:31:25 -0400 Date: Fri, 23 May 2008 18:30:57 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@localhost.localdomain To: Miklos Szeredi cc: hch@infradead.org, linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [patch 06/14] hfsplus: remove hfsplus_permission() In-Reply-To: Message-ID: References: <20080521171458.077908538@szeredi.hu> <20080521171549.964767446@szeredi.hu> <20080523092114.GD27119@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 23 May 2008, Miklos Szeredi wrote: > And so I strongly suggest this patch as well. Apparently this feature > is not even used by anybody, otherwise somebody would have noticed > when Trond's fix broke execute permission checking on regular files... And I'm very strongly against this. If you wanted to rip out the resource inode logic, it would be more than this. At worst this code does nothing right now, so why this sudden rush to remove this without even an attempt of fixing it? bye, Roman