From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753020AbYEYXqg (ORCPT ); Sun, 25 May 2008 19:46:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751260AbYEYXq1 (ORCPT ); Sun, 25 May 2008 19:46:27 -0400 Received: from cnc.isely.net ([64.81.146.143]:54222 "EHLO cnc.isely.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbYEYXq0 (ORCPT ); Sun, 25 May 2008 19:46:26 -0400 Date: Sun, 25 May 2008 18:46:24 -0500 (CDT) From: Mike Isely Reply-To: Mike Isely To: Alan Cox cc: Video4Linux list , Linux Kernel Mailing List , Mauro Carvalho Chehab , Mike Isely at pobox Subject: Re: [PATCH] video4linux: Push down the BKL In-Reply-To: <20080522223700.2f103a14@core> Message-ID: References: <20080522223700.2f103a14@core> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 May 2008, Alan Cox wrote: > For most drivers the generic ioctl handler does the work and we update it > and it becomes the unlocked_ioctl method. Older drivers use the usercopy > method so we make it do the work. Finally there are a few special cases. > > Signed-off-by: Alan Cox The pvrusb2 driver already should not require the BKL. Though since this driver (like every V4L driver) is using video_usercopy() then it's obviously going along for the ride here with respect to the overall issue here in pushing the lock down into video_usercopy(). In the mean time, for the pvrusb2 portion of this patch... Acked-By: Mike Isely -Mike -- Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8