From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754451AbYE1U0E (ORCPT ); Wed, 28 May 2008 16:26:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752755AbYE1UZx (ORCPT ); Wed, 28 May 2008 16:25:53 -0400 Received: from relay1.sgi.com ([192.48.171.29]:56053 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752230AbYE1UZw (ORCPT ); Wed, 28 May 2008 16:25:52 -0400 Date: Wed, 28 May 2008 13:25:50 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Pekka Enberg cc: Paul Mundt , LKML , cooloney@kernel.org, akpm@linux-foundation.org, dhowells@redhat.com, mpm@selenic.com Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB In-Reply-To: <483DBA85.2060502@cs.helsinki.fi> Message-ID: References: <20080528153648.GA27783@linux-sh.org> <483DBA85.2060502@cs.helsinki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 May 2008, Pekka Enberg wrote: > (cc'ing linux-kernel) > > Paul Mundt wrote: > > I have no idea why you are maintaining the page->index case here, it's > > completely broken for page cache pages. Unless someone more familiar with > > the page->index BUG_ON() tests objects, the BUG_ON() there should be > > removed completely. Neither Christoph nor I were able to work out what the > > point of the page->index tests were, and no one else has spoken up about > > them, so it's likely safe to treat them as bogus. > > We use kobjsize() for pointers returned from do_mmap() which is why I kept the > page->index case. Are we using PageCompound for those as well? What does do_mmap have to do with page->index?