From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813AbYE1U3R (ORCPT ); Wed, 28 May 2008 16:29:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753231AbYE1U3I (ORCPT ); Wed, 28 May 2008 16:29:08 -0400 Received: from relay1.sgi.com ([192.48.171.29]:33634 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753222AbYE1U3F (ORCPT ); Wed, 28 May 2008 16:29:05 -0400 Date: Wed, 28 May 2008 13:29:05 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Pekka Enberg cc: Paul Mundt , LKML , cooloney@kernel.org, akpm@linux-foundation.org, dhowells@redhat.com, mpm@selenic.com Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB In-Reply-To: <483DBFC3.1070108@cs.helsinki.fi> Message-ID: References: <20080528153648.GA27783@linux-sh.org> <483DBA85.2060502@cs.helsinki.fi> <483DBFC3.1070108@cs.helsinki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 May 2008, Pekka Enberg wrote: > Christoph Lameter wrote: > > > We use kobjsize() for pointers returned from do_mmap() which is why I kept > > > the > > > page->index case. Are we using PageCompound for those as well? > > > > What does do_mmap have to do with page->index? > > I don't know how the nommu code is supposed to work. I simply assumed it has a > reason for being there and that compound_order() is not enough to handle that. Could the nommu people either tell us what this is all about? Or junk the code. This looks very wrong.