Re: [PATCH] spi: two bug-fixes

[Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>]

On Wed, 4 Jun 2008, Adrian Bunk wrote:

> On Wed, Jun 04, 2008 at 05:11:14PM +0200, Guennadi Liakhovetski wrote:
> > Index: linux-2.6/drivers/gpio/mcp23s08.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/gpio/mcp23s08.c	2008-06-04 12:11:26.000000000 +0200
> > +++ linux-2.6/drivers/gpio/mcp23s08.c	2008-06-04 12:11:50.000000000 +0200
> > @@ -178,7 +178,7 @@
> >  
> >  	mutex_lock(&mcp->lock);
> >  	t = mcp23s08_read_regs(mcp, 0, mcp->cache, sizeof mcp->cache);
> > -	if (t < 0) {
> > +	if ((int)t < 0) {
> >  		seq_printf(s, " I/O ERROR %d\n", t);
> >  		goto done;
> >  	}
> >...
> 
> The better fix of making "t" signed by Roel Kluin is already as
> commit 1d1c1d9b557a12320174058d2d313ffb0f8611f4 in Linus' tree.

Good, thanks for letting know! David, please, let me know if you want me 
to resubmit the second part of the patch separately, or if you can just 
extract it from the original one.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer