From: Christoph Lameter <clameter@sgi.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
David Howells <dhowells@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
cooloney@kernel.org, mpm@selenic.com
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB, v2.
Date: Tue, 10 Jun 2008 11:30:19 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0806101128450.17349@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <19f34abd0806101118r5edbc065t8a19b69abf9aea5c@mail.gmail.com>
On Tue, 10 Jun 2008, Vegard Nossum wrote:
> Are you sure it shouldn't be virt_addr_valid()? If yes, can you please
> explain the difference? Thanks :-)
from include/asm-x86/page.h
#define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
#define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
Yes virt_addr_valid is better to use. I was thinking too much using the
basic ops.
next prev parent reply other threads:[~2008-06-10 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 7:27 Paul Mundt
2008-06-05 16:26 ` David Howells
2008-06-10 17:30 ` Christoph Lameter
2008-06-10 18:18 ` Vegard Nossum
2008-06-10 18:30 ` Christoph Lameter [this message]
2008-06-11 7:33 ` Paul Mundt
2008-06-11 23:22 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806101128450.17349@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=cooloney@kernel.org \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®