From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: vcgandhi1@aol.com, linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org
Subject: [PATCH] Fix serial_match_port() for dynamic major tty-device numbers
Date: Sun, 22 Jun 2008 00:45:25 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0806220037250.461@axis700.grange> (raw)
In-Reply-To: <8CA914AC0F6817C-1684-368@webmail-nc03.sysops.aol.com>
As reported by Vipul Gandhi, the current serial_match_port() doesn't work
for tty-devices using dynamic major number allocation. Fix it.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Tested-by: Vipul Gandhi <vcgandhi1@aol.com>
---
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 0f5a179..593ae85 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -1949,7 +1949,9 @@ struct uart_match {
static int serial_match_port(struct device *dev, void *data)
{
struct uart_match *match = data;
- dev_t devt = MKDEV(match->driver->major, match->driver->minor) + match->port->line;
+ struct tty_driver *tty_drv = match->driver->tty_driver;
+ dev_t devt = MKDEV(tty_drv->major, tty_drv->minor_start) +
+ match->port->line;
return dev->devt == devt; /* Actually, only one tty per port */
}
next parent reply other threads:[~2008-06-21 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8CA6D5E4DEA920C-1128-2973@webmail-nb07.sysops.aol.com>
[not found] ` <Pine.LNX.4.64.0804160046460.6851@axis700.grange>
[not found] ` <8CA6D67D9E313CC-1128-35BB@webmail-nb07.sysops.aol.com>
[not found] ` <8CA6D6D112DB4D4-1128-38B0@webmail-nb07.sysops.aol.com>
[not found] ` <Pine.LNX.4.64.0804170103040.7335@axis700.grange>
[not found] ` <8CA6E48B50204C0-15A8-47D0@webmail-nb06.sysops.aol.com>
[not found] ` <Pine.LNX.4.64.0804171657320.6716@axis700.grange>
[not found] ` <8CA6EC102F70775-15A8-8B4A@webmail-nb06.sysops.aol.com>
[not found] ` <Pine.LNX.4.64.0804171915180.6716@axis700.grange>
[not found] ` <8CA6EF5BC26E069-12A0-1888@webmail-nc13.sysops.aol.com>
[not found] ` <Pine.LNX.4.64.0804181700300.5725@axis700.grange>
[not found] ` <8CA6FF4B03B281A-E10-2E1C@webmail-nf05.sim.aol.com>
[not found] ` <Pine.LNX.4.64.0804231108170.5160@axis700.grange>
[not found] ` <8CA73B83C791846-148-41B9@webmail-nb17.sysops.aol.com>
[not found] ` <Pine.LNX.4.64.0804241557340.5283@axis700.grange>
[not found] ` <8CA914AC0F6817C-1684-368@webmail-nc03.sysops.aol.com>
2008-06-21 22:45 ` Guennadi Liakhovetski [this message]
2008-06-24 22:22 ` Andrew Morton
2008-06-24 22:54 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806220037250.461@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vcgandhi1@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®