From: Julia Lawall <julia@diku.dk>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH 3/14] arch/ia64: Eliminate NULL test and memset after alloc_bootmem
Date: Tue, 24 Jun 2008 20:00:01 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0806241959180.26777@ask.diku.dk> (raw)
In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3062D2476@orsmsx505.amr.corp.intel.com>
On Tue, 24 Jun 2008, Luck, Tony wrote:
> > In addition the current alloc_bootmem() is a macro that uses __alloc_bootmem
> > which most defintely can return NULL.
>
> ...
> panic("Out of memory");
> return NULL;
> }
>
> Oops ... that "panic" call before the "return NULL" makes the
> above statement totally wrong.
Thanks. I was worried there might be somewhere a non-aborting version of
panic. But that would be really confusing...
julia
prev parent reply other threads:[~2008-06-24 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 8:22 Julia Lawall
2008-06-24 17:42 ` Luck, Tony
2008-06-24 17:55 ` Julia Lawall
2008-06-24 17:59 ` Luck, Tony
2008-06-24 17:56 ` Luck, Tony
2008-06-24 18:00 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806241959180.26777@ask.diku.dk \
--to=julia@diku.dk \
--cc=akinobu.mita@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®