From: Mikulas Patocka <mpatocka@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH 1/2] Avoid bio_endio recursion
Date: Thu, 3 Jul 2008 18:54:53 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0807031843480.10463@engineering.redhat.com> (raw)
In-Reply-To: <20080703220449.20688451@lxorguk.ukuu.org.uk>
On Thu, 3 Jul 2008, Alan Cox wrote:
>> I use the old IDE driver, I don't see a reason why driver should create
>> SCSI requests and lower layer translate them to ATA commands.
>
> Because modern drives are basically SCSI devices. Once you turn on NCQ
> and stuff you need all the midlayer queueing magic ...
There is no piece of SCSI protocol in SATA disks. The command and response
FIS of SATA standard contain legacy IDE registers, there's nothing about
SCSI. Even the NCQ commands are done via IDE registers, not SCSI command
block. It seems like someone wanted to save few weeks of coding by reusing
the SCSI disk queuing ... and created a lot of other problems (example: if
you have disk error with IDE driver, it dumps IDE registers into log ...
if you have disk error with SATA driver, it dumps sense key ... but
there's no sense key in SATA standard ... the driver just had to make up
one because it pretends to be SCSI).
Mikulas
next prev parent reply other threads:[~2008-07-03 22:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 5:22 Mikulas Patocka
2008-06-24 6:08 ` Neil Brown
2008-06-24 14:36 ` Mikulas Patocka
2008-06-24 8:07 ` Jens Axboe
2008-06-24 14:27 ` Mikulas Patocka
2008-06-25 8:24 ` Jens Axboe
2008-06-26 0:13 ` Mikulas Patocka
2008-06-26 7:07 ` Jens Axboe
2008-07-02 4:09 ` Mikulas Patocka
2008-07-02 8:00 ` Alan Cox
2008-07-03 21:03 ` Mikulas Patocka
2008-07-02 8:25 ` Jens Axboe
2008-07-03 21:08 ` Mikulas Patocka
2008-07-03 21:04 ` Alan Cox
2008-07-03 22:54 ` Mikulas Patocka [this message]
2008-07-03 23:00 ` Alan Cox
2008-07-03 23:51 ` Mikulas Patocka
2008-07-03 23:44 ` Alan Cox
2008-07-04 3:26 ` Mikulas Patocka
2008-07-04 8:11 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0807031843480.10463@engineering.redhat.com \
--to=mpatocka@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome