mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mike Travis <travis@sgi.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] x86: BUILD_IRQ say .text to avoid .data.percpu
Date: Mon, 21 Jul 2008 18:41:26 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0807211828470.26173@blonde.site> (raw)

When I edit the x86_64 Makefile to -fno-unit-at-a-time, bootup panics
on 0xCCs in IRQ0x3e_interrupt(): IRQ0x20_interrupt etc. have got linked
into .data.percpu.  Perhaps there are other ways of triggering that:
specify ".text" in the BUILD_IRQ() macro for safety.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
I've been using -fno-unit-at-a-time (to lessen inlining, for easier
debugging) for a long time, but never saw this until Mike's percpu mods
came in: I mention this so you're on the lookout, just in case other
things are more likely to go into the wrong section now.  (I did give
Mike a private headsup on this a couple of weeks ago, in case it helped
with problems he was having with percpu, but in fact it didn't help.)

 arch/x86/kernel/irqinit_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 2.6.26-git/arch/x86/kernel/irqinit_64.c	2008-07-18 11:33:31.000000000 +0100
+++ linux/arch/x86/kernel/irqinit_64.c	2008-07-18 16:07:00.000000000 +0100
@@ -43,7 +43,7 @@
 
 #define BUILD_IRQ(nr)				\
 	asmlinkage void IRQ_NAME(nr);		\
-	asm("\n.p2align\n"			\
+	asm("\n.text\n.p2align\n"		\
 	    "IRQ" #nr "_interrupt:\n\t"		\
 	    "push $~(" #nr ") ; "		\
 	    "jmp common_interrupt");

             reply	other threads:[~2008-07-21 17:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 17:41 Hugh Dickins [this message]
2008-07-21 23:25 ` Mike Travis
2008-07-22  3:49   ` Hugh Dickins
2008-07-24 10:44 ` Ingo Molnar
2008-07-25 18:45   ` CONFIG_FRAME_POINTER [was [PATCH] x86: BUILD_IRQ say .text] Hugh Dickins
2008-07-25 21:46     ` Benjamin Herrenschmidt
2008-07-26 11:02       ` Hugh Dickins
2008-07-26 12:36         ` Benjamin Herrenschmidt
2008-07-28 13:52           ` Gabriel Paubert
2008-07-28 14:41     ` Ingo Molnar
2008-07-28 14:54       ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0807211828470.26173@blonde.site \
    --to=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®