From: Hugh Dickins <hugh@veritas.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oliver Pinter <oliver.pntr@gmail.com>,
stable@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC, 2.6.26.2-rc1] exec: remove some includes
Date: Sat, 2 Aug 2008 20:53:32 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0808022046310.20316@blonde.site> (raw)
In-Reply-To: <alpine.LFD.1.10.0808021239040.3874@nehalem.linux-foundation.org>
On Sat, 2 Aug 2008, Linus Torvalds wrote:
> On Sat, 2 Aug 2008, Oliver Pinter wrote:
> >
> > [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]
> >
> > fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
> > mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.
>
> Why on earth would this be -stable material?
Of course it isn't -stable material, I don't know what Oliver's on.
Maybe he noticed akpm's "unbreak arm" comment and thought it was
fixing some pre-existing breakage: no, akpm restored swap.h to
fix the arm build. Then after this commit, we had to restore
pagemap.h to fix avr32 and !CONFIG_SWAP builds.
Prime material for -unstable, I'm ashamed to say.
Hugh
next prev parent reply other threads:[~2008-08-02 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 19:45 Oliver Pinter
2008-08-02 19:39 ` Linus Torvalds
2008-08-02 19:53 ` Hugh Dickins [this message]
2008-08-02 19:56 ` Willy Tarreau
2008-08-02 20:03 ` Oliver Pinter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0808022046310.20316@blonde.site \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.pntr@gmail.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®