From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Manish Katiyar <mkatiyar@gmail.com>,
kernel-janitors@vger.kernel.org, astarikovskiy@suse.de,
vladimir.p.lebedev@intel.com, LKML <linux-kernel@vger.kernel.org>,
trivial@vger.kernel.org
Subject: Re: [PATCH] Remove warning 'unused variable battery' in drivers/acpi/sbs.c
Date: Sun, 3 Aug 2008 13:18:05 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0808031317280.14866@shark.he.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0808031528420.31606@wrl-59.cs.helsinki.fi>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1035 bytes --]
On Sun, 3 Aug 2008, Ilpo Järvinen wrote:
> On Sun, 3 Aug 2008, Manish Katiyar wrote:
>
> > Below patch removes the following warning:
> > drivers/acpi/sbs.c: In function 'acpi_battery_remove':
> > drivers/acpi/sbs.c:819: warning: unused variable 'battery'
> >
> >
> >
> > Signed-off-by:- "Manish Katiyar" <mkatiyar@gmail.com>
> >
> > ---
> > drivers/acpi/sbs.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
> > index 10a3651..8493603 100644
> > --- a/drivers/acpi/sbs.c
> > +++ b/drivers/acpi/sbs.c
> > @@ -816,7 +816,9 @@ static int acpi_battery_add(struct acpi_sbs *sbs, int id)
> >
> > static void acpi_battery_remove(struct acpi_sbs *sbs, int id)
> > {
> > +#ifdef CONFIG_ACPI_SYSFS_POWER || CONFIG_ACPI_PROCFS_POWER
>
> I don't think you can use || operator in ifdef like that... ...Try
> #if defined(...) || (...) instead.
Did the patch sumbitter try to build this with the patch in place???
--
~Randy
prev parent reply other threads:[~2008-08-03 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 7:24 Manish Katiyar
2008-08-03 12:30 ` Ilpo Järvinen
2008-08-03 20:18 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0808031317280.14866@shark.he.net \
--to=rdunlap@xenotime.net \
--cc=astarikovskiy@suse.de \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=trivial@vger.kernel.org \
--cc=vladimir.p.lebedev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®