Re: [GIT PULL] XFS update for 2.6.27-rc4

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Wed, 13 Aug 2008, Lachlan McIlroy wrote:
> The following changes since commit 30a2f3c60a84092c8084dfe788b710f8d0768cd4:
>   Linus Torvalds (1):
>         Linux 2.6.27-rc3
> 
> are available in the git repository at:
> 
>   git://oss.sgi.com:8090/xfs/linux-2.6 master
> 
> David Chinner (12):
>       [XFS] extend completions to provide XFS object flush requirements

This change (commit 39d2f1ab2a36ac527a6c41cfe689f50c239eaca3) seems to
have broken the m68k build:

|   CC      arch/m68k/kernel/asm-offsets.s
| In file included from linux/include/linux/mm_types.h:12,
|                  from linux/include/linux/sched.h:61,
|                  from linux/arch/m68k/kernel/asm-offsets.c:12:
| linux/include/linux/completion.h: In function 'try_wait_for_completion':
| linux/include/linux/completion.h:80: error: dereferencing pointer to incomplete type
| linux/include/linux/completion.h: In function 'completion_done':
| linux/include/linux/completion.h:99: error: dereferencing pointer to incomplete type
| make[3]: *** [arch/m68k/kernel/asm-offsets.s] Error 1
| make[2]: *** [prepare0] Error 2
| make[1]: *** [sub-make] Error 2

(cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/42080/)

Apparently there was not sufficient time between entering linux-next and
Linus' tree to notice this breakage before, while the original patch was already
posted on July 11...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds