From: Roman Zippel <zippel@linux-m68k.org>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Check hfs_bnode_find return value
Date: Fri, 29 Aug 2008 04:07:21 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0808290405480.2507@localhost.localdomain> (raw)
In-Reply-To: <20080826172332.GA22058@alice>
Hi,
On Tue, 26 Aug 2008, Eric Sesterhenn wrote:
> --- linux/fs/hfsplus/brec.c.orig 2008-08-26 19:18:56.000000000 +0200
> +++ linux/fs/hfsplus/brec.c 2008-08-26 19:19:27.000000000 +0200
> @@ -304,6 +304,8 @@ static struct hfs_bnode *hfs_bnode_split
> /* update next bnode header */
> if (new_node->next) {
> struct hfs_bnode *next_node = hfs_bnode_find(tree, new_node->next);
> + if (IS_ERR(next_node))
> + return next_node;
> next_node->prev = new_node->this;
> hfs_bnode_read(next_node, &node_desc, 0, sizeof(node_desc));
> node_desc.prev = cpu_to_be32(next_node->prev);
Al Viro already fixed this for HFS in a better way, could you please adopt
his solution?
bye, Roman
next prev parent reply other threads:[~2008-08-29 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 17:23 Eric Sesterhenn
2008-08-29 2:07 ` Roman Zippel [this message]
2008-09-04 12:17 ` Eric Sesterhenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0808290405480.2507@localhost.localdomain \
--to=zippel@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®