From: Roman Zippel <zippel@linux-m68k.org>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Fix another bug in hfsplus when reading a corrupted image
Date: Fri, 29 Aug 2008 04:21:18 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0808290409220.2507@localhost.localdomain> (raw)
In-Reply-To: <20080826125909.GA21266@alice>
Hi,
On Tue, 26 Aug 2008, Eric Sesterhenn wrote:
> Problem is that there is no ext_tree, causing the NULL-pointer
> dereference in hfsplus_init(). This fixes the issue by checking the ext_tree in
> hfsplus_get_block() and aborting early enoug.
The problem is worse, a corrupted extent for the extent file itself may
try to get an impossible extent, causing a deadlock if I see it correctly.
A better fix would be to check the inode number after the first_blocks
checks and fail if it's the extent file, as according to the spec the
extent file should have no extent for itself.
bye, Roman
next prev parent reply other threads:[~2008-08-29 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 12:59 Eric Sesterhenn
2008-08-29 2:21 ` Roman Zippel [this message]
2008-09-03 17:14 ` Eric Sesterhenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0808290409220.2507@localhost.localdomain \
--to=zippel@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®