mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Nir Tzachar <nir@tzachar.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Nir Tzachar <tzachar@grad120a.cs.bgu.ac.il>,
	linux-kernel@vger.kernel.org, zippel@linux-m68k.org,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] ncurses based config
Date: Thu, 4 Sep 2008 08:28:07 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0809040822440.19666@shark.he.net> (raw)
In-Reply-To: <9b2db90b0809032155h6ed5df9ey846de96779022d11@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2880 bytes --]

On Thu, 4 Sep 2008, Nir Tzachar wrote:

> Good morning.
> 
> Sorry for the delay, it was night here...
> 
> > Hi,
> > >
> > > On Wednesday 03 September 2008, Nir Tzachar wrote:
> > > > This patch was inspired by the kernel projects page, where an ncurses
> > > > replacement for menuconfig was mentioned (by Sam Ravnborg).
> > > >
> > > > Building on menuconfig, this patch implements a more modern look
> > interface using
> > > > ncurses and ncurses' satellite libraries (menu, panel, form). The
> > implementation
> > > > does not depend on lxdialog, which is currently distributed with the
> > kernel.
> > > >
> > > > The only change outside of nconf.c is due to a name clash: both ncurses
> > and
> > > > lkc.h define a fucntion named menu_init(). I changed the internal
> > version's
> > > > name.
> > > >
> > > > Please consider the patch for merging. Comments are appreciated.
> > >
> > > Could you please tell what kernel version is it against?
> >
> > It applies cleanly to 2.6.27-rc5-git4 FWIW.
> >
> 
> I based the patch on current git tree. Is a more stable version preferable?

No, that's fine.

> >
> > > I'm getting the following error on make nconfig (and also on make
> > menuconfig
> > > which works fine without this patch) with the current Linus' tree:
> > >
> > >   HOSTCC  scripts/kconfig/conf.o
> > >   HOSTCC  scripts/kconfig/kxgettext.o
> > >   HOSTCC  scripts/kconfig/nconf.o
> > >   HOSTCC  scripts/kconfig/zconf.tab.o
> > > scripts/kconfig/zconf.tab.c: In function ÿÿconf_parseÿÿ:
> > > scripts/kconfig/zconf.tab.c:2258: warning: implicit declaration of
> > function ÿÿmenu_initÿÿ
> > >   HOSTLD  scripts/kconfig/nconf
> > > scripts/kconfig/nconf arch/x86/Kconfig
> > > make[1]: *** [nconfig] Segmentation fault
> > > make: *** [nconfig] Error 2
> >
> > Need to change all /menu_init/ in zconf.tab.c* to /_menu_init/.
> >
> 
> I believe the patch does change these lines.

Perhaps the patch was missing some pieces then.  It does not
contain any changes to the zconf* files.

> >
> > Need to strip trailing whitespace on new source code lines.
> >
> 
> scripts/checkpatch.pl did not report anything here. Maybe git-email-send
> messed up the patch??

Too bad.

quilt reported several of those when I applied the patch.
AFAIK, git also will report that.

These lines have trailing spaces:

57:+nconf-objs  := nconf.o zconf.tab.o 
85:+HOSTLOADLIBES_nconf = -lmenu -lpanel -lform -lncurses 
86:+HOSTCFLAGS_nconf.o  = 
87:+LDFLAGS_nconf.o     = 

> > I'm seeing cyan (?) foreground on black background.  Is that the colors
> > that were planned?
> >
> 
> > Instructions are dark blue on black -- cannot read them.
> >
> 
> Well, colors were never my strong point ;) If someone can come up with a
> better color scheme I'll be more than happy to change.

-- 
~Randy

  parent reply	other threads:[~2008-09-04 15:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 19:11 Nir Tzachar
2008-09-03 19:38 ` Bartlomiej Zolnierkiewicz
2008-09-03 20:02   ` Randy.Dunlap
2008-09-03 20:03     ` Randy.Dunlap
2008-09-03 20:18     ` Bartlomiej Zolnierkiewicz
2008-09-03 20:29     ` Alejandro Riveira Fernández
2008-09-04 15:02       ` Bartlomiej Zolnierkiewicz
     [not found]     ` <9b2db90b0809032155h6ed5df9ey846de96779022d11@mail.gmail.com>
2008-09-04 15:28       ` Randy.Dunlap [this message]
2008-09-04  4:22 ` KOSAKI Motohiro
2008-09-04 10:36 ` Alejandro Riveira Fernández
2008-09-05  8:27 ` [PATCH] ncurses based config V2 Nir Tzachar
2008-09-05 13:49   ` Alejandro Riveira Fernández
2008-09-05 19:59   ` Willy Tarreau
2008-09-06  5:41     ` Nir Tzachar
2008-09-14 10:52       ` Willy Tarreau
2008-09-17 11:58         ` Nir Tzachar
2008-11-24 18:44     ` Sam Ravnborg
2008-11-25  2:33       ` Roman Zippel
2008-11-25  8:04         ` Nir Tzachar
2008-11-25 16:02           ` Roman Zippel
2008-11-25  8:01       ` Nir Tzachar
2008-11-25  8:11         ` Sam Ravnborg
2008-11-25 12:35           ` Nir Tzachar
2008-11-29 21:40 ` sss Nir Tzachar
2008-11-29 21:40   ` [PATCH] nconfig V3 Nir Tzachar
     [not found] <b86dt-3nV-39@gated-at.bofh.it>
     [not found] ` <b86wB-3HU-1@gated-at.bofh.it>
     [not found]   ` <b86Qa-4k2-53@gated-at.bofh.it>
     [not found]     ` <b879t-4DG-23@gated-at.bofh.it>
2008-09-04 12:21       ` [PATCH] ncurses based config Bodo Eggert
     [not found]         ` <9b2db90b0809040517v4478f1b9md69ea07ef9c62c86@mail.gmail.com>
2008-09-04 14:37           ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0809040822440.19666@shark.he.net \
    --to=rdunlap@xenotime.net \
    --cc=bzolnier@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nir@tzachar.com \
    --cc=tzachar@grad120a.cs.bgu.ac.il \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®