From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm -v3] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h
Date: Mon, 6 Oct 2008 10:48:22 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0810061047440.5594@anakin> (raw)
In-Reply-To: <1223263964.5872.20.camel@yhuang-dev.sh.intel.com>
On Mon, 6 Oct 2008, Huang Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> asm/atomic.h contains both declaration and implementation of atomic_t. So
> there are some implementation related files included in asm/atomic.h. And
> atomic_t is a typedef. Combination of above makes it impossible to use
> atomic_t in files included by atomic.h. Such as atomic_t can not be used
> in linux/kernel.h on i386, because it is included by asm/atomic.h.
>
> It is reasonable to separate declaration from implementation. So a new
> file atomic_def.h is added for every architecture to accommodate the
> declaration of atomic_t.
And how many of these atomic_def.h are identical?
asm-generic?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2008-10-06 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 3:32 Huang Ying
2008-10-06 5:00 ` Ingo Molnar
2008-10-06 8:48 ` Geert Uytterhoeven [this message]
2008-10-07 1:09 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0810061047440.5594@anakin \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®