From: Christoph Lameter <cl@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] SLUB - define OO_ macro instead of hardcoded numbers
Date: Wed, 22 Oct 2008 11:45:55 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0810221144290.6054@quilx.com> (raw)
In-Reply-To: <20081022183055.GN9639@localhost>
On Wed, 22 Oct 2008, Cyrill Gorcunov wrote:
> Looks really good for me (if it worth anything). But Christoph
> doesn't OO_SHIT inspired by u16 too which means we could use
> MAX_OBJ_PER_PAGE in form you mentoined but maybe we should define
>
> #define OO_SHIFT bits_in(page.objects) to point out why we use
> 16 not 14, not 18 or whatever? How do you think?
The choice of the bit size in page.objects is determined by the available
bytes there. The choice of the OO_SHIFT (nice typo there) is determined by
the use of a 32bit int that we want to cut into two halves.
next prev parent reply other threads:[~2008-10-22 18:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:18 Cyrill Gorcunov
2008-10-22 16:28 ` Christoph Lameter
2008-10-22 16:35 ` Cyrill Gorcunov
2008-10-22 16:53 ` Cyrill Gorcunov
2008-10-22 17:21 ` Cyrill Gorcunov
2008-10-22 17:47 ` Christoph Lameter
2008-10-22 17:50 ` Pekka Enberg
2008-10-22 17:58 ` Cyrill Gorcunov
2008-10-22 18:01 ` Pekka Enberg
2008-10-22 18:10 ` Christoph Lameter
2008-10-22 18:15 ` Cyrill Gorcunov
2008-10-22 18:24 ` Christoph Lameter
2008-10-22 18:30 ` Cyrill Gorcunov
2008-10-22 18:45 ` Christoph Lameter [this message]
2008-10-22 18:52 ` Cyrill Gorcunov
2008-10-22 18:42 ` Cyrill Gorcunov
2008-10-22 18:49 ` Christoph Lameter
2008-10-22 18:53 ` Cyrill Gorcunov
2008-10-22 18:03 ` Christoph Lameter
2008-10-22 17:54 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0810221144290.6054@quilx.com \
--to=cl@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®