From: Christoph Lameter <cl@linux-foundation.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, travis@sgi.com,
linux-next@vger.kernel.org
Subject: Re: Git next: Second stage of cpu_alloc patches
Date: Wed, 5 Nov 2008 07:59:01 -0600 (CST) [thread overview]
Message-ID: <Pine.LNX.4.64.0811050757360.11867@quilx.com> (raw)
In-Reply-To: <19f34abd0811042352q2df6ed0r6c92a35159d2b04c@mail.gmail.com>
On Wed, 5 Nov 2008, Vegard Nossum wrote:
> Just in case it helps track down the problem: Adding percpu=100000 to
> the kernel command line got the thing booting for me. The number
> itself was picked at random, but it worked on the first try. The
> machine is a single-core P4 3.0 GHz with HT, 1G RAM, using slightly
> modified F9 config.
Its only happening if !CONFIG_MODULES because then the reserve size is
zero. The second stage patches fix that because there will then be other
uses of the allocator so that reserves are always needed. This hunk from
the second stage fixes the !CONFIG_MODULES issue.
Index: linux-2.6/include/linux/percpu.h
===================================================================
--- linux-2.6.orig/include/linux/percpu.h 2008-11-05 07:41:22.134646124 -0600
+++ linux-2.6/include/linux/percpu.h 2008-11-05 07:44:28.603155403 -0600
@@ -44,11 +44,7 @@
extern unsigned int percpu_reserve;
/* Enough to cover all DEFINE_PER_CPUs in kernel, including modules. */
#ifndef PERCPU_AREA_SIZE
-#ifdef CONFIG_MODULES
#define PERCPU_RESERVE_SIZE 8192
-#else
-#define PERCPU_RESERVE_SIZE 0
-#endif
#define PERCPU_AREA_SIZE \
(__per_cpu_end - __per_cpu_start + percpu_reserve)
next prev parent reply other threads:[~2008-11-05 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 2:56 Christoph Lameter
2008-11-05 3:52 ` Andrew Morton
2008-11-05 7:26 ` Stephen Rothwell
2008-11-05 7:52 ` Vegard Nossum
2008-11-05 13:59 ` Christoph Lameter [this message]
2008-11-05 13:54 ` Christoph Lameter
2008-11-05 16:27 ` Andrew Morton
2008-11-05 21:12 ` Vegard Nossum
2008-11-05 21:24 ` Andrew Morton
2008-11-05 23:58 ` Johannes Weiner
2008-11-06 0:54 ` Stephen Rothwell
2008-11-06 14:54 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811050757360.11867@quilx.com \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=travis@sgi.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®