From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Subject: Re: [PATCH 2/4 v1] i.MX31: Image Processing Unit DMA and IRQ drivers
Date: Tue, 11 Nov 2008 19:13:48 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0811111856500.8435@axis700.grange> (raw)
In-Reply-To: <e9c3a7c20811110737m4b17e0fcp45bcec86f937b9ea@mail.gmail.com>
Hi Dan,
On Tue, 11 Nov 2008, Dan Williams wrote:
> On Tue, Nov 11, 2008 at 2:36 AM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > I still have no solution to this ->client_count problem. Is this a bug and
> > there should be a way to release a channel (including decrementint the
> > client_count) without unregistering the client, or am I missing something?
> >
>
> Hi Guennadi,
>
> I am currently working on improving this situation:
>
> http://marc.info/?l=linux-kernel&m=122463374500746&w=2
>
> Please have a look.
Thanks for the pointer, I looked at it.
1. ASYNC_TX_ACK: one either sets this flag immediately on a descriptor in
flags for ->device_prep_dma_memcpy() (like in
dma_async_memcpy_buf_to_buf()), which would mean "may be recycled
automatically" or you don't set it, then the descriptor is kept, until you
call async_tx_ack() on it. Are you going to preserve the async_tx_ack()
implementation? In this case dma-device drivers have to scan their
descriptors to do garbage-collection?... Wouldn't it be better to
introduce an explicit call to free a descriptor, like in this my patch:
http://marc.info/?l=linux-arm-kernel&m=122607472721145&w=2 (see the last
hank for include/linux/dmaengine.h)?
2. channel client-count: am I right, that with the current implementation
one cannot free a channel in a way, that its client_count got decremented,
and the ->device_free_chan_resources() method be called for it? Is this
going to be addressed too or I am missing something and channel freeing
has to be done differently?
3. you write
> 3b/ Remove the client registration infrastructure
which means, there should be an interface to free a channel explicitly?
because until now unregistering the client was the only way (that I found)
to free channels...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
prev parent reply other threads:[~2008-11-11 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0811071454000.4513@axis700.grange>
[not found] ` <Pine.LNX.4.64.0811071512500.4513@axis700.grange>
2008-11-11 9:36 ` Guennadi Liakhovetski
2008-11-11 15:37 ` Dan Williams
2008-11-11 18:13 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811111856500.8435@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=dan.j.williams@intel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®