From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756901AbYKTSRT (ORCPT ); Thu, 20 Nov 2008 13:17:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752195AbYKTSRG (ORCPT ); Thu, 20 Nov 2008 13:17:06 -0500 Received: from nlpi025.sbcis.sbc.com ([207.115.36.54]:43437 "EHLO nlpi025.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbYKTSRE (ORCPT ); Thu, 20 Nov 2008 13:17:04 -0500 Date: Thu, 20 Nov 2008 12:16:28 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@quilx.com To: Cyrill Gorcunov cc: Pekka Enberg , LKML , Andrew Morton Subject: Re: mm: slab - __cache_alloc NULL prefetch fix In-Reply-To: <20081120170148.GD7363@localhost> Message-ID: References: <20081120164400.GC7363@localhost> <20081120170148.GD7363@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -2.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Nov 2008, Cyrill Gorcunov wrote: > even having prefetch(NULL) as valid we do check if > object is not NULL anyway so I thought there is no > need to prefetch(NULL) in case of fail. The object is only checked if SLAB_DEBUG is on.