From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755550AbYKUK2B (ORCPT ); Fri, 21 Nov 2008 05:28:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753145AbYKUK1x (ORCPT ); Fri, 21 Nov 2008 05:27:53 -0500 Received: from winston.telenet-ops.be ([195.130.137.75]:58836 "EHLO winston.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752903AbYKUK1w (ORCPT ); Fri, 21 Nov 2008 05:27:52 -0500 Date: Fri, 21 Nov 2008 11:27:48 +0100 (CET) From: Geert Uytterhoeven To: Alan Cox cc: David Daney , linux-mips , linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Make BUG() __noreturn. In-Reply-To: <20081121100035.3f5a640b@lxorguk.ukuu.org.uk> Message-ID: References: <49260E4C.8080500@caviumnetworks.com> <20081121100035.3f5a640b@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Nov 2008, Alan Cox wrote: > On Thu, 20 Nov 2008 17:26:36 -0800 > David Daney wrote: > > > MIPS: Make BUG() __noreturn. > > > > Often we do things like put BUG() in the default clause of a case > > statement. Since it was not declared __noreturn, this could sometimes > > lead to bogus compiler warnings that variables were used > > uninitialized. > > > > There is a small problem in that we have to put a magic while(1); loop to > > fool GCC into really thinking it is noreturn. > > That sounds like your __noreturn macro is wrong. > > Try using __attribute__ ((__noreturn__)) > > if that works then fix up the __noreturn definitions for the MIPS and gcc > you have. Nope, gcc is too smart: $ cat a.c int f(void) __attribute__((__noreturn__)); int f(void) { } $ gcc -c -Wall a.c a.c: In function f: a.c:6: warning: `noreturn' function does return $ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds