From: Guennadi Liakhovetski <lg@denx.de>
To: rpurdie@rpsys.net
Cc: linux-kernel@vger.kernel.org
Subject: leds/leds-pca9532.c: sleeping function called in .brightness_set()
Date: Mon, 24 Nov 2008 10:51:51 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0811241041130.4148@axis700.grange> (raw)
Hi,
this seems to explicitly violate the API as documented in
include/linux/leds.h:
/* Set LED brightness level */
/* Must not sleep, use a workqueue if needed */
void (*brightness_set)(struct led_classdev *led_cdev,
enum led_brightness brightness);
and also contradicts some other drivers, e.g., pca955x, which do use a
workqueue as suggested: leds-pca9532.c::pca9532_set_brightness uses a
mutex for locking and calls i2c_smbus functions directly. Needs to be
fixed (if it hasn't been fixed yet), probably, also vor 2.6.27-stable.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
next reply other threads:[~2008-11-24 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 9:51 Guennadi Liakhovetski [this message]
2008-12-03 10:03 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811241041130.4148@axis700.grange \
--to=lg@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®