From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754083AbYLCTt5 (ORCPT ); Wed, 3 Dec 2008 14:49:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751659AbYLCTto (ORCPT ); Wed, 3 Dec 2008 14:49:44 -0500 Received: from winston.telenet-ops.be ([195.130.137.75]:55492 "EHLO winston.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbYLCTtn (ORCPT ); Wed, 3 Dec 2008 14:49:43 -0500 Date: Wed, 3 Dec 2008 20:49:39 +0100 (CET) From: Geert Uytterhoeven To: Stephen Hemminger , "David S. Miller" cc: Stephen Rothwell , netdev@vger.kernel.org, linux-next@vger.kernel.org, LKML Subject: m68k 8390 breakage (was: Re: linux-next: Tree for December 3) In-Reply-To: <20081203183602.c06f8c39.sfr@canb.auug.org.au> Message-ID: References: <20081203183602.c06f8c39.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Dec 2008, Stephen Rothwell wrote: > Status of my local build tests will be at > http://kisskb.ellerman.id.au/linux-next . If maintainers want to give > advice about cross compilers/configs that work, we are always open to add > more builds. Since a few days, m68k defconfig and allmodconfig give: | drivers/net/lib8390.c:1014: undefined reference to `ei_start_xmit' | drivers/net/lib8390.c:1015: undefined reference to `ei_get_stats' | drivers/net/lib8390.c:1016: undefined reference to `ei_set_multicast_list' (cfr. e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/58795/) git bisect run on "make ARCH=m68k mac_defconfig vmlinux" tells me: 8884c092e5e4f9a1b6e44f2e02a3eb5481af87ab is first bad commit commit 8884c092e5e4f9a1b6e44f2e02a3eb5481af87ab Author: Stephen Hemminger Date: Tue Nov 25 18:12:49 2008 -0800 8390: add common net_device ops Fix the defactoring of ei_XXX functions in 8390 and 8390p. Remove the tx_timeout hack since no driver including the 3c503 overrides tx_timeout at this time, looks like a legacy thing. Also, since several drivers all have same hooks, provide common netdev_ops. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds