From: Guennadi Liakhovetski <lg@denx.de>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Trent Piepho <xyzzy@speakeasy.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [GIT PULL] LED updates for 2.6.29
Date: Sun, 11 Jan 2009 02:20:06 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0901110216030.24501@axis700.grange> (raw)
In-Reply-To: <1231633983.5330.32.camel@dax.rpnet.com>
On Sun, 11 Jan 2009, Richard Purdie wrote:
> Ok, these are now queued in the LED tree:
>
> http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/log/
>
> I did merge the last three patches in one and make some changes to deal
> with some other outstanding issues. Let me know ASAP if there are any
> problems.
As already replied off-list, looks good mostly to me. Just have to keep in
mind, that this version relies on drivers initialising their struct
led_classdev instances to 0. Maybe it would be better to set the new
max_brightness to 0 (or to LED_FULL) explicitly for them, as I was doing
in my v2 of the patch.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
next prev parent reply other threads:[~2009-01-11 1:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 11:23 Richard Purdie
2009-01-09 20:37 ` Trent Piepho
2009-01-09 23:19 ` Richard Purdie
2009-01-10 12:31 ` Trent Piepho
2009-01-11 0:33 ` Richard Purdie
2009-01-11 1:20 ` Guennadi Liakhovetski [this message]
2009-01-11 5:43 ` Trent Piepho
2009-01-11 11:49 ` Richard Purdie
2009-01-11 12:58 ` Trent Piepho
2009-01-11 13:39 ` Richard Purdie
2009-01-11 0:33 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0901110216030.24501@axis700.grange \
--to=lg@denx.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpurdie@rpsys.net \
--cc=torvalds@linux-foundation.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®