From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756822AbZA2UCt (ORCPT ); Thu, 29 Jan 2009 15:02:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751879AbZA2UCk (ORCPT ); Thu, 29 Jan 2009 15:02:40 -0500 Received: from harold.telenet-ops.be ([195.130.133.65]:46884 "EHLO harold.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbZA2UCk (ORCPT ); Thu, 29 Jan 2009 15:02:40 -0500 Date: Thu, 29 Jan 2009 21:02:29 +0100 (CET) From: Geert Uytterhoeven To: Andrew Morton cc: Andrea Righi , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Roman Zippel , David Howells , Hirokazu Takata Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions In-Reply-To: <20090127174158.519e5abd.akpm@linux-foundation.org> Message-ID: References: <1232919337-21434-1-git-send-email-righi.andrea@gmail.com> <20090127174158.519e5abd.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jan 2009, Andrew Morton wrote: > On Sun, 25 Jan 2009 22:35:37 +0100 > Andrea Righi wrote: > > > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h > > index a7cdc48..b132d69 100644 > > --- a/include/asm-generic/pgtable-nopmd.h > > +++ b/include/asm-generic/pgtable-nopmd.h > > @@ -4,6 +4,7 @@ > > #ifndef __ASSEMBLY__ > > > > #include > > +#include > > > > struct mm_struct; > > > > Why not include the preferred ? > > > BTW, I only tested this on x86 and x86_64. This needs more testing because it > > touches also a lot of other architectures. > > Hopefully Geert, Roman, David and Hirokazu Takata will have time to > help out here. atari_defconfig builds fine and boots on ARAnyM. sun3_defconfig fails with: | CC mm/memory.o | mm/memory.c: In function 'free_pmd_range': | mm/memory.c:176: error: implicit declaration of function '__pmd_free_tlb' | mm/memory.c: In function '__pmd_alloc': | mm/memory.c:2903: error: implicit declaration of function 'pmd_alloc_one_bug' | mm/memory.c:2903: warning: initialization makes pointer from integer without a cast | mm/memory.c:2917: error: implicit declaration of function 'pmd_free' | make[3]: *** [mm/memory.o] Error 1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds