Re: [PATCH -next/mmotm/resend] kmemtrace: fix printk formats

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Thu, 29 Jan 2009, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kmemtrace printk warnings:
> 
> kernel/trace/kmemtrace.c:142: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t'
> kernel/trace/kmemtrace.c:147: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc:      Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> ---
>  kernel/trace/kmemtrace.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20090123.orig/kernel/trace/kmemtrace.c
> +++ linux-next-20090123/kernel/trace/kmemtrace.c
> @@ -139,12 +139,12 @@ kmemtrace_print_alloc_compress(struct tr
>  		return TRACE_TYPE_PARTIAL_LINE;
>  
>  	/* Requested */
> -	ret = trace_seq_printf(s, "%4ld   ", entry->bytes_req);
> +	ret = trace_seq_printf(s, "%4zd   ", entry->bytes_req);
>  	if (!ret)
>  		return TRACE_TYPE_PARTIAL_LINE;
>  
>  	/* Allocated */
> -	ret = trace_seq_printf(s, "%4ld   ", entry->bytes_alloc);
> +	ret = trace_seq_printf(s, "%4zd   ", entry->bytes_alloc);
>  	if (!ret)
>  		return TRACE_TYPE_PARTIAL_LINE;

%4zu?

size_t is unsigned, ssize_t is signed.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds