From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619AbZBWOxB (ORCPT ); Mon, 23 Feb 2009 09:53:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754347AbZBWOwx (ORCPT ); Mon, 23 Feb 2009 09:52:53 -0500 Received: from extu-mxob-2.symantec.com ([216.10.194.135]:50817 "EHLO extu-mxob-2.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754316AbZBWOww (ORCPT ); Mon, 23 Feb 2009 09:52:52 -0500 Date: Mon, 23 Feb 2009 14:51:05 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.anvils To: Nick Piggin cc: Pekka Enberg , Matt Mackall , KOSAKI Motohiro , David Vrabel , Johannes Weiner , Andrew Morton , Chas Williams , Evgeniy Polyakov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Nick Piggin Subject: Re: [patch 1/7] slab: introduce kzfree() In-Reply-To: <200902240101.26362.nickpiggin@yahoo.com.au> Message-ID: References: <499BE7F8.80901@csr.com> <499DB6EC.3020904@cs.helsinki.fi> <200902240101.26362.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Feb 2009, Nick Piggin wrote: > > Well, the buffer is only non-modified in the case of one of the > allocators (SLAB). All others overwrite some of the data region > with their own metadata. > > I think it is OK to use const, though. Because k(z)free has the > knowledge that the data will not be touched by the caller any > longer. Sorry, you're not adding anything new to the thread here. Yes, the caller is surrendering the buffer, so we can get away with calling the argument const; and Linus argues that's helpful in the case of kfree (to allow passing a const pointer without having to cast it). My contention is that kzfree(const void *ptr) is nonsensical because it says please zero this buffer without modifying it. But the change has gone in, I seem to be the only one still bothered by it, and I've conceded that the "z" might stand for zap rather than zero. So it may be saying please hide the contents of this buffer, rather than please zero it. And then it can be argued that the modification is an implementation detail which happens (like other housekeeping internal to the sl?b allocator) only after the original buffer has been freed. Philosophy. Hugh