mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Masami Hiramatsu <mhiramat@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: [PATCH] module: Kill warning: label 'free_init' defined but not used
Date: Wed, 25 Mar 2009 20:43:06 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0903252041190.14101@anakin> (raw)

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 kernel/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 1196f5d..df00a1b 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2288,8 +2288,8 @@ static noinline struct module *load_module(void __user *umod,
 	ftrace_release(mod->module_core, mod->core_size);
  free_unload:
 	module_unload_free(mod);
- free_init:
 #if defined(CONFIG_MODULE_UNLOAD) && defined(CONFIG_SMP)
+ free_init:
 	percpu_modfree(mod->refptr);
 #endif
 	module_free(mod, mod->module_init);
-- 
1.6.2


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2009-03-25 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 19:43 Geert Uytterhoeven [this message]
2009-03-25 19:54 ` Jaswinder Singh Rajput
2009-03-25 20:05   ` Geert Uytterhoeven
2009-03-25 20:22     ` Jaswinder Singh Rajput
2009-03-25 22:52 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0903252041190.14101@anakin \
    --to=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome