From: Dan Carpenter <error27@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: eteo@redhat.com
Subject: [patch] char/raw.c locking on error
Date: Fri, 27 Mar 2009 13:28:48 +0300 (EAT) [thread overview]
Message-ID: <Pine.LNX.4.64.0903262243150.4167@usbsys.site> (raw)
There is an unlock_kernel missing.
This bug was found by smatch (http://repo.or.cz/w/smatch.git/). Compile
tested only, sorry.
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/char/raw.c 2009-03-26 22:40:27.000000000 +0300
+++ devel/drivers/char/raw.c 2009-03-26 22:41:20.000000000 +0300
@@ -90,6 +90,7 @@
blkdev_put(bdev, filp->f_mode);
out:
mutex_unlock(&raw_mutex);
+ unlock_kernel();
return err;
}
next reply other threads:[~2009-03-27 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:28 Dan Carpenter [this message]
2009-03-27 15:48 ` Jonathan Corbet
2009-03-27 21:36 ` Michael Tokarev
2009-03-27 21:44 ` Jonathan Corbet
2009-03-28 0:23 ` Alan Cox
[not found] <ckhDP-7Ey-1@gated-at.bofh.it>
[not found] ` <ckmtX-6ZA-25@gated-at.bofh.it>
[not found] ` <ckrWP-7iQ-33@gated-at.bofh.it>
[not found] ` <cks6g-7wu-13@gated-at.bofh.it>
2009-03-27 23:49 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0903262243150.4167@usbsys.site \
--to=error27@gmail.com \
--cc=eteo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®