From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758214AbZEELbQ (ORCPT ); Tue, 5 May 2009 07:31:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752778AbZEELa7 (ORCPT ); Tue, 5 May 2009 07:30:59 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:54351 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbZEELa6 (ORCPT ); Tue, 5 May 2009 07:30:58 -0400 Date: Tue, 5 May 2009 13:30:53 +0200 (CEST) From: Julia Lawall To: gregkh@suse.de, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: p80211wext.c: possible problem with IW_ENCODE_ALG_WEP Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The file drivers/staging/wlan-ng/p80211wext.c contains the following code: (starting at line 1490 in a recent linux-next) if (!(ext->alg & IW_ENCODE_ALG_WEP)) { pr_debug("asked to set a non wep key :("); return -EINVAL; } The reference to IW_ENCODE_ALG_WEP seems to refer to the following definitions in include/linux/wireless.h /* struct iw_encode_ext ->alg */ #define IW_ENCODE_ALG_NONE 0 #define IW_ENCODE_ALG_WEP 1 #define IW_ENCODE_ALG_TKIP 2 #define IW_ENCODE_ALG_CCMP 3 #define IW_ENCODE_ALG_PMK 4 #define IW_ENCODE_ALG_AES_CMAC 5 But if the alg field returns true for a bit and with IW_ENCODE_ALG_WEP, then it would also return true for a bit and with IW_ENCODE_ALG_CCMP and IW_ENCODE_ALG_AES_CMAC. Is this what is intended, or should the test be encoded in another way? julia