From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757752AbZEFQ7x (ORCPT ); Wed, 6 May 2009 12:59:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760267AbZEFQ7l (ORCPT ); Wed, 6 May 2009 12:59:41 -0400 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:44662 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759566AbZEFQ7k (ORCPT ); Wed, 6 May 2009 12:59:40 -0400 Date: Wed, 6 May 2009 17:57:14 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@blonde.anvils To: Chris Wright cc: Izik Eidus , Andrea Arcangeli , Rik van Riel , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, device@lanana.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au Subject: Re: [PATCH 3/6] ksm: change the KSM_REMOVE_MEMORY_REGION ioctl. In-Reply-To: <20090506164945.GD15712@x200.localdomain> Message-ID: References: <1241475935-21162-1-git-send-email-ieidus@redhat.com> <1241475935-21162-2-git-send-email-ieidus@redhat.com> <1241475935-21162-3-git-send-email-ieidus@redhat.com> <1241475935-21162-4-git-send-email-ieidus@redhat.com> <4A00DF9B.1080501@redhat.com> <4A014C7B.9080702@redhat.com> <20090506133434.GX16078@random.random> <4A019719.7030504@redhat.com> <20090506164945.GD15712@x200.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 May 2009, Chris Wright wrote: > > I like merge. For madvise() approach I had used: > > +#define MADV_SHAREABLE 12 /* can share identical pages */ > +#define MADV_UNSHAREABLE 13 /* can not share identical pages */ > > But those are maybe better put as MADV_(UN)MERGEABLE > (gets a bit confusing when you talk of merging vmas ;-) That's true, I hadn't remembered that. Not _very_ confusing, but the last thing I'd want is to bully everyone into changing their familiar name for something, and the result just as poor. No need to decide today anyway: let's see how others feel. Hugh