From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jeff Mahoney <jeffm@suse.com>, Al Viro <viro@zeniv.linux.org.uk>
Cc: reiserfs-devel@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: [PATCH] reiserfs: xattr - Kill warning if !CONFIG_REISERFS_FS_XATTR
Date: Sat, 16 May 2009 18:58:16 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0905161857370.31230@anakin> (raw)
If CONFIG_REISERFS_FS_XATTR is not set, I get:
fs/reiserfs/xattr.c: In function 'reiserfs_xattr_init':
fs/reiserfs/xattr.c:993: warning: unused variable 'privroot'
since commit ab17c4f02156c4f75d7fa43a5aa2a7f942d47201 ("reiserfs: fixup
xattr_root caching").
Move the definition of `privroot' inside the section protected by #ifdef
CONFIG_REISERFS_FS_XATTR to kill the warning.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
fs/reiserfs/xattr.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
index 2237e10..3c767d9 100644
--- a/fs/reiserfs/xattr.c
+++ b/fs/reiserfs/xattr.c
@@ -990,9 +990,10 @@ int reiserfs_lookup_privroot(struct super_block *s)
int reiserfs_xattr_init(struct super_block *s, int mount_flags)
{
int err = 0;
- struct dentry *privroot = REISERFS_SB(s)->priv_root;
#ifdef CONFIG_REISERFS_FS_XATTR
+ struct dentry *privroot = REISERFS_SB(s)->priv_root;
+
err = xattr_mount_check(s);
if (err)
goto error;
--
1.6.3
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
reply other threads:[~2009-05-16 16:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0905161857370.31230@anakin \
--to=geert@linux-m68k.org \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®