From: Hugh Dickins <hugh@veritas.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <ak@linux.intel.com>,
Ian Campbell <ian.campbell@citrix.com>,
Jakub Jelinek <jakub@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix print out of function which called WARN_ON()
Date: Sun, 17 May 2009 15:43:14 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0905171536470.23834@blonde.anvils> (raw)
In-Reply-To: <alpine.LFD.2.01.0905161342150.3301@localhost.localdomain>
On Sat, 16 May 2009, Linus Torvalds wrote:
>
> This patch not only avoids the warnings and gets the right caller
> information, it cleans up the code too:
>
> - it uses '%pS' instead of of sprint_symbol
> - char function[KSYM_SYMBOL_LEN];
This should be a big improvement, because that buffer on the stack
was netting lots of stale return addresses, printed out with ?s in
the warning's dump_stack(). I had been wanting to add a memset,
but your %pS should circumvent the need for that nicely.
Hugh
next prev parent reply other threads:[~2009-05-17 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 16:17 Ian Campbell
2009-05-15 17:52 ` Linus Torvalds
2009-05-15 19:50 ` Andi Kleen
2009-05-16 20:47 ` Linus Torvalds
2009-05-17 14:43 ` Hugh Dickins [this message]
2009-05-17 22:18 ` Linus Torvalds
2009-05-17 22:24 ` David Miller
2009-05-17 22:47 ` Linus Torvalds
2009-05-17 22:45 ` Hugh Dickins
2009-05-17 22:54 ` Linus Torvalds
2009-05-18 9:09 ` Ian Campbell
2009-05-18 14:11 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0905171536470.23834@blonde.anvils \
--to=hugh@veritas.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=ian.campbell@citrix.com \
--cc=jakub@redhat.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®