From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754552AbZGDVd3 (ORCPT ); Sat, 4 Jul 2009 17:33:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753518AbZGDVdV (ORCPT ); Sat, 4 Jul 2009 17:33:21 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:56177 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbZGDVdU (ORCPT ); Sat, 4 Jul 2009 17:33:20 -0400 Date: Sat, 4 Jul 2009 23:33:21 +0200 (CEST) From: Julia Lawall To: florian@openwrt.org, openwrt-devel@lists.openwrt.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 3/3] drivers/vlynq/vlynq.c: Fix resource size off by 1 error Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall In this case, the calls to request_mem_region, ioremap, and release_mem_region all have a consistent length argument, len, but since in other files (res->end - res->start) + 1, equivalent to resource_size(res), is used for a resource-typed structure res, one could consider whether the same should be done here. The problem was found using the following semantic patch: (http://www.emn.fr/x-info/coccinelle/) // @@ struct resource *res; @@ - (res->end - res->start) + 1 + resource_size(res) @@ struct resource *res; @@ - res->end - res->start + BAD(resource_size(res)) // Signed-off-by: Julia Lawall --- drivers/vlynq/vlynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c --- a/drivers/vlynq/vlynq.c 2009-06-24 21:18:50.000000000 +0200 +++ b/drivers/vlynq/vlynq.c 2009-07-04 21:37:28.000000000 +0200 @@ -703,7 +703,7 @@ static int vlynq_probe(struct platform_d dev->mem_start = mem_res->start; dev->mem_end = mem_res->end; - len = regs_res->end - regs_res->start; + len = resource_size(regs_res); if (!request_mem_region(regs_res->start, len, dev_name(&dev->dev))) { printk(KERN_ERR "%s: Can't request vlynq registers\n", dev_name(&dev->dev));