From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755754AbZGKHvH (ORCPT ); Sat, 11 Jul 2009 03:51:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753784AbZGKHuw (ORCPT ); Sat, 11 Jul 2009 03:50:52 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:58848 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754093AbZGKHuu (ORCPT ); Sat, 11 Jul 2009 03:50:50 -0400 Date: Sat, 11 Jul 2009 09:49:48 +0200 (CEST) From: Julia Lawall To: jgarzik@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/5] drivers/ata: Move a dereference below a NULL test Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // Signed-off-by: Julia Lawall --- drivers/ata/pata_at91.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -u -p a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c @@ -312,11 +312,12 @@ err_ide_ioremap: static int __devexit pata_at91_remove(struct platform_device *pdev) { struct ata_host *host = dev_get_drvdata(&pdev->dev); - struct at91_ide_info *info = host->private_data; + struct at91_ide_info *info; struct device *dev = &pdev->dev; if (!host) return 0; + info = host->private_data; ata_host_detach(host);