From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756614AbZGKHwX (ORCPT ); Sat, 11 Jul 2009 03:52:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756008AbZGKHwJ (ORCPT ); Sat, 11 Jul 2009 03:52:09 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:39555 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467AbZGKHwH (ORCPT ); Sat, 11 Jul 2009 03:52:07 -0400 Date: Sat, 11 Jul 2009 09:51:14 +0200 (CEST) From: Julia Lawall To: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 5/5] staging/otus: Move a dereference below a NULL test Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // Signed-off-by: Julia Lawall --- drivers/staging/otus/wwrap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c --- a/drivers/staging/otus/wwrap.c +++ b/drivers/staging/otus/wwrap.c @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work) { struct usbdrv_private *macp = container_of(work, struct usbdrv_private, kevent); - zdev_t *dev = macp->device; + zdev_t *dev; if (macp == NULL) { return; } + dev = macp->device; if (test_and_set_bit(0, (void *)&smp_kevent_Lock)) {