From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbZHAI6B (ORCPT ); Sat, 1 Aug 2009 04:58:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751935AbZHAI6A (ORCPT ); Sat, 1 Aug 2009 04:58:00 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:50996 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbZHAI56 (ORCPT ); Sat, 1 Aug 2009 04:57:58 -0400 Date: Sat, 1 Aug 2009 10:55:24 +0200 (CEST) From: Julia Lawall To: jgarzik@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 9/10] drivers/ata: introduce missing kfree Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Error handling code following a kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // Signed-off-by: Julia Lawall --- drivers/ata/pata_at91.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c index 5702aff..46fb883 100644 --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c @@ -261,7 +261,8 @@ static int __devinit pata_at91_probe(struct platform_device *pdev) if (IS_ERR(info->mck)) { dev_err(dev, "failed to get access to mck clock\n"); - return -ENODEV; + ret = -ENODEV; + goto err_clk_get; } info->cs = board->chipselect; @@ -308,6 +309,7 @@ err_alt_ioremap: err_ide_ioremap: clk_put(info->mck); +err_clk_get: kfree(info); return ret;