From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754525AbZHCJWO (ORCPT ); Mon, 3 Aug 2009 05:22:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753223AbZHCJWN (ORCPT ); Mon, 3 Aug 2009 05:22:13 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:57583 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbZHCJWM (ORCPT ); Mon, 3 Aug 2009 05:22:12 -0400 Date: Mon, 3 Aug 2009 11:22:09 +0200 (CEST) From: Julia Lawall To: Guennadi Liakhovetski Cc: Kurt Garloff , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/5] drivers/scsi: Use DIV_ROUND_CLOSEST In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d but is perhaps more readable. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @haskernel@ @@ #include @depends on haskernel@ expression x,__divisor; @@ - (((x) + ((__divisor) / 2)) / (__divisor)) + DIV_ROUND_CLOSEST(x,__divisor) // Signed-off-by: Julia Lawall --- drivers/scsi/tmscsim.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c index 9a42734..e580db5 100644 --- a/drivers/scsi/tmscsim.c +++ b/drivers/scsi/tmscsim.c @@ -1125,7 +1125,8 @@ dc390_MsgIn_set_sync (struct dc390_acb* pACB, struct dc390_srb* pSRB) { if (! (bval & FAST_SCSI)) wval1++; printk (KERN_INFO "DC390: Target %i: Sync transfer %i.%1i MHz, Offset %i\n", pDCB->TargetID, - 40/wval1, ((40%wval1)*10+wval1/2)/wval1, pDCB->SyncOffset & 0x0f); + 40/wval1, DIV_ROUND_CLOSEST((40%wval1)*10, wval1), + pDCB->SyncOffset & 0x0f); } dc390_reprog (pACB, pDCB);