From: Julia Lawall <julia@diku.dk>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/8] drivers/media/video/uvc: introduce missing kfree
Date: Sun, 13 Sep 2009 22:45:51 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0909132245220.31000@ask.diku.dk> (raw)
In-Reply-To: <200909132239.21806.laurent.pinchart@ideasonboard.com>
> > - if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) && query == UVC_GET_DEF)
> > - return -EIO;
> > + if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) &&
> > + query == UVC_GET_DEF) {
> > + ret = -EIO;
> > + goto out;
> > + }
>
> This check can be moved before kmalloc(), removing the need to free memory in
> case of error.
>
> Julia, do you want to submit a modified patch or should I do it myself ?
I can do it. I will send a revised patch shortly.
julia
next prev parent reply other threads:[~2009-09-13 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 16:21 Julia Lawall
2009-09-13 20:39 ` Laurent Pinchart
2009-09-13 20:45 ` Julia Lawall [this message]
2009-09-13 20:55 ` Julia Lawall
2009-09-15 9:44 ` Laurent Pinchart
2009-09-15 9:54 ` Julia Lawall
2009-09-15 9:58 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0909132245220.31000@ask.diku.dk \
--to=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®