From: Julia Lawall <julia@diku.dk>
To: Bernd Petrovitsch <bernd@firmix.at>
Cc: al@alarsen.net, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: sizeof vs strlen (was Re: [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp)
Date: Thu, 12 Nov 2009 16:33:52 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0911121632540.19779@ask.diku.dk> (raw)
In-Reply-To: <1258021335.3689.41.camel@tara.firmix.at>
On Thu, 12 Nov 2009, Bernd Petrovitsch wrote:
> On Thu, 2009-11-12 at 08:49 +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > As observed by Joe Perches, sizeof of a constant string includes the
> > trailing 0. If what is wanted is to check the initial characters of
> > another string, this trailing 0 should not be taken into account. If an
> > exact match is wanted, strcmp should be used instead.
> [...]
> > strncmp(foo, abc,
> > - sizeof(abc)
> > + sizeof(abc)-1
> > )
> > // </smpl>
> Am I the only one who find "strlen()" instead of "sizeof()-1" here much
> more readable (and to the point).
>
> As for run-time, it shouldn't make a difference for static/constant
> strings as gcc should be able calculate the length at compile time. And
> if the string is not constant, sizeof() is probably wrong anyways.
Does gcc have access to the definition of strlen? It does not seem to be
an inlined function, eg in lib/string.c.
julia
next prev parent reply other threads:[~2009-11-12 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 7:49 [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp Julia Lawall
2009-11-12 9:25 ` Anders Larsen
2009-11-12 10:05 ` Julia Lawall
2009-11-12 10:14 ` Julia Lawall
2009-11-12 10:22 ` sizeof vs strlen (was Re: [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp) Bernd Petrovitsch
2009-11-12 10:37 ` Julia Lawall
2009-11-12 15:33 ` Julia Lawall [this message]
2009-11-13 16:42 ` Bernd Petrovitsch
2009-11-12 23:49 ` [PATCH 4/4] fs/qnx4: decrement sizeof size in strncmp David Wagner
2009-11-13 0:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0911121632540.19779@ask.diku.dk \
--to=julia@diku.dk \
--cc=al@alarsen.net \
--cc=bernd@firmix.at \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®