From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755891Ab0CHVgJ (ORCPT ); Mon, 8 Mar 2010 16:36:09 -0500 Received: from mgw2.diku.dk ([130.225.96.92]:39332 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755746Ab0CHVgG (ORCPT ); Mon, 8 Mar 2010 16:36:06 -0500 Date: Mon, 8 Mar 2010 22:36:01 +0100 (CET) From: Julia Lawall To: Christophe Jaillet Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch] arch/powerpc/platforms/pseries/ras.c - cleanup In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Mar 2010, Christophe Jaillet wrote: > From: Christophe Jaillet > > Hi, here is a patch against arch/powerpc/platforms/pseries/ras.c. > > No need to memset (.., 0, ...) a buffer that is complety filled by a memcpy > the line after. I find 14 occurrences of this in linux-next. Could it be useful for something? julia > > > Signed-off-by: Christophe Jaillet > > --- > > diff --git a/arch/powerpc/platforms/pseries/ras.c > b/arch/powerpc/platforms/pseries/ras.c > index 2b548af..7a401ed 100644 > --- a/arch/powerpc/platforms/pseries/ras.c > +++ b/arch/powerpc/platforms/pseries/ras.c > @@ -276,7 +276,6 @@ static struct rtas_error_log *fwnmi_get_errinfo(struct > pt_regs *regs) > (errdata >= rtas.base && errdata < rtas.base + rtas.size - 16)) { > savep = __va(errdata); > regs->gpr[3] = savep[0]; /* restore original r3 */ > - memset(mce_data_buf, 0, RTAS_ERROR_LOG_MAX); > memcpy(mce_data_buf, (char *)(savep + 1), RTAS_ERROR_LOG_MAX); > errhdr = (struct rtas_error_log *)mce_data_buf; > } else { > > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >