mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de,
	kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: smatch_scripts/whitespace_only.sh
Date: Wed, 10 Mar 2010 11:14:53 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.1003101113330.24684@ask.diku.dk> (raw)
In-Reply-To: <20100310101224.GC6321@bicker>

On Wed, 10 Mar 2010, Dan Carpenter wrote:

> I wrote a script to check that a patch only changes white space.
> It compiles the files before and after the patch is applied and 
> verifies that they are the same.
> 
> You'll need to compile smatch:
> 	git pull git://repo.or.cz/smatch.git
> 	make
> 	cd /path/to/kernel/src/
> 	/path/to/smatch_scripts/whitespace_only.sh <patch>
> 
> Adding or removing parenthesis and curly braces counts as a code 
> change.  Changes to comments, #if 0, white space changes do not.
> 
> You can fix a lot of style violations if you limit yourself to 
> adding and removing tabs, spaces and new lines.  Then the next 
> patch could remove unneeded parenthesis.  It would be easier to
> audit that way instead of everything mixed together.
> 
> regards,
> dan carpenter
> 
> PS.  I feel really bad slagging the newbies trying to help.  
> Could we fix checkpatch.pl to not complain about line lengths?

I hope not...  Are newbies really put off by having to add a newline here 
and there?

julia

> Also could we tell them to stay in staging where no one cares
> about git blame?
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2010-03-10 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 10:12 smatch_scripts/whitespace_only.sh Dan Carpenter
2010-03-10 10:14 ` Julia Lawall [this message]
2010-03-10 14:27   ` smatch_scripts/whitespace_only.sh Dan Carpenter
2010-03-10 14:38     ` smatch_scripts/whitespace_only.sh Julia Lawall
2010-03-10 18:11       ` smatch_scripts/whitespace_only.sh Joe Perches
2010-03-11  9:59         ` smatch_scripts/whitespace_only.sh Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1003101113330.24684@ask.diku.dk \
    --to=julia@diku.dk \
    --cc=devel@driverdev.osuosl.org \
    --cc=error27@gmail.com \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®